permissions: add self-checkout #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
force-pushed
the
fix-self-checkout
branch
4 times, most recently
from
f589607
to
9f1d393
Compare
ntarocco
commented
Oct 16, 2024
| loan = kwargs.get("record", {}) | ||
| is_patron_current_user = current_user.id == int(loan.get("patron_pid")) | ||
| loan = kwargs["record"] | ||
| is_patron_current_user = current_user.id == int(loan["patron_pid"]) |
There was a problem hiding this comment.
We should really avoid using .get when the dict field is required. We need to fail early in these cases.
ntarocco
commented
Oct 16, 2024
| @@ -163,36 +168,41 @@ def __init__(self, record): | |||
| super().__init__(UserNeed(int(record["patron_pid"])), backoffice_access_action) | |||
|
|
|||
|
|
|||
| _is_authenticated_user = [ | |||
There was a problem hiding this comment.
Moved outside to declare them once, and not on each func call.
ntarocco
force-pushed
the
fix-self-checkout
branch
2 times, most recently
from
4a050bf
to
91ff204
Compare
kpsherva
reviewed
Oct 17, 2024
setup.cfg
Outdated
| @@ -28,6 +28,7 @@ zip_safe = False | |||
| install_requires = | |||
| # Invenio core modules | |||
| invenio-app>=1.3.4,<1.4.0 | |||
| invenio-db[postgresql,mysql]>=1.0.14,<2.0.0 | |||
There was a problem hiding this comment.
won't this install both dbs? also, seems like versioning is missing?
There was a problem hiding this comment.
This will install only the drivers/packages, we do this everywhere now.
Versioning was optional, it is now installed by default.
kpsherva
reviewed
Oct 17, 2024
| @@ -26,6 +26,11 @@ def get_active_loan_pid_and_item_pid(): | |||
| if total > 0: | |||
| return t["pid"], active_loan[0]["pid"] | |||
|
|
|||
| item = Item.get_record_by_pid("itmeid-1") | |||
There was a problem hiding this comment.
typo, probably this is breaking tests
ntarocco
force-pushed
the
fix-self-checkout
branch
3 times, most recently
from
ab4f66d
to
0fb8b73
Compare
ntarocco
force-pushed
the
fix-self-checkout
branch
from
0fb8b73
to
42277a3
Compare
kpsherva
approved these changes
Oct 25, 2024
sakshamarora1
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.